fix(parquet): write single file if option is set #17009
Open
+109
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
core
hknlof
force-pushed
the
fix/write-single-parquet
branch
from
1c05032 to
f1d58c5
Compare
|
I restarted the checks |
github-actions
bot
added
documentation
|
Sorry for the delay -- this PR seems to have quite. few conflicts. |
hknlof
force-pushed
the
fix/write-single-parquet
branch
from
00148b2 to
651cfb8
Compare
github-actions
bot
removed
documentation
github-actions
bot
removed
sqllogictest
No worries! My bad, I forgot to sync before rebasing the branch onto main again. Thx! |
Jefffrey
reviewed
Sep 21, 2025
Comment on lines
+86
to
+94
| let path = if file_type.get_ext() != DEFAULT_PARQUET_EXTENSION | ||
| && options.single_file_output | ||
| { | ||
| let mut path = path.to_owned(); | ||
| path.push_str(SINGLE_FILE_EXTENSION); | ||
| path | ||
| } else { | ||
| path.to_owned() | ||
| }; |
There was a problem hiding this comment.
This part confuses me; If I'm not wrong file_type.get_ext() != DEFAULT_PARQUET_EXTENSION will always be true, because:
datafusion/datafusion/datasource-parquet/src/file_format.rs
Lines 157 to 162 in 602475f
Comment on lines
+250
to
+254
| let test_path = std::path::Path::new(&path); | ||
| assert!( | ||
| test_path.is_dir(), | ||
| "No extension and default DataFrameWriteOptons should have yielded a dir." | ||
| ); |
There was a problem hiding this comment.
I think we would need to also check there are indeed multiple parquet files
Comment on lines
+288
to
+292
| let test_path = std::path::Path::new(&path); | ||
| assert!( | ||
| test_path.is_file(), | ||
| "No extension and DataFrameWriteOptons::with_single_file_output(true) should have yielded a single file." | ||
| ); |
There was a problem hiding this comment.
Similarly here we would need to check that only one file is written, not just a file is written
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#13323
Which issue does this PR close?
DataFrameWriteOptions::with_single_file_outputproduces a directory #13323Rationale for this change
DF.write_parquetwrites multiple files / one directory even ifoptions.single_file_outputis set.What changes are included in this PR?
Introduce an internal
.singleextension.Are these changes tested?
Yes, tests are part of this PR.
Are there any user-facing changes?
Not in this implementation. There might be, if we decide to move to an
FileSinkConfigbased solution.Quoting: #13323 (comment)